[Stable10] Catch internal server error from remote on decline#35321
Merged
Conversation
11 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #35321 +/- ##
==============================================
- Coverage 64.64% 64.64% -0.01%
- Complexity 20089 20093 +4
==============================================
Files 1289 1289
Lines 76943 76946 +3
Branches 1300 1300
==============================================
+ Hits 49738 49739 +1
- Misses 26821 26823 +2
Partials 384 384
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35321 +/- ##
==============================================
- Coverage 64.64% 64.64% -0.01%
- Complexity 20089 20093 +4
==============================================
Files 1289 1289
Lines 76943 76946 +3
Branches 1300 1300
==============================================
+ Hits 49738 49739 +1
- Misses 26821 26823 +2
Partials 384 384
Continue to review full report at Codecov.
|
phil-davis
approved these changes
May 24, 2019
13 tasks
Contributor
|
@VicDeo Following the steps from the OP I get a 404:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #35178
Description
Handle 500 exception on declining a share
Motivation and Context
Before 10.2 response for declining non-existing shares was 500
#34786 changes HTTP status from 500 to 410
But declining any non-existing share for OC lower than 10.2 still causing unhandled exception.
How Has This Been Tested?
Types of changes
Checklist: